Setup a NULL provider #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gowthamsk-arm
force-pushed
the
null_provider
branch
from
031fc50 to
1470a7b
Compare
|
Will breakdown the commits so its easier to review. |
gowthamsk-arm
force-pushed
the
null_provider
branch
4 times, most recently
from
86e7c96 to
8bb0be2
Compare
tgonzalezorlandoarm
requested changes
Jan 18, 2024
There was a problem hiding this comment.
- I see that we are dealing with conversions from c and rust in the provider itself. I think it would be good to have an abstraction layer on the openssl2 layer which handles the conversions, and on the provider we just deal make calls to those conversions to get safe Rust types, so that we only deal with Rust on the provider level.
- Some nits/things to check and minor changes
Yes thanks for comment. Will fix this. :) |
|
Should we also add the .h header files with the necessary information for calling bindgen (and include bindgen in the Cargo.toml) so that we can regenerate the bindings for any platforms? This would be consistent with our approach on the rest of the projects |
|
This approach would be better. Will make the changes. |
gowthamsk-arm
force-pushed
the
null_provider
branch
from
8bb0be2 to
3060f15
Compare
gowthamsk-arm
commented
Jan 31, 2024
gowthamsk-arm
force-pushed
the
null_provider
branch
2 times, most recently
from
f047feb to
40e59fb
Compare
tgonzalezorlandoarm
requested changes
Feb 7, 2024
ionut-arm
reviewed
Feb 7, 2024
gowthamsk-arm
force-pushed
the
null_provider
branch
10 times, most recently
from
1f3d23a to
9965c81
Compare
tgonzalezorlandoarm
requested changes
Feb 13, 2024
gowthamsk-arm
force-pushed
the
null_provider
branch
2 times, most recently
from
719e5ff to
9809d8d
Compare
tgonzalezorlandoarm
requested changes
Feb 14, 2024
gowthamsk-arm
force-pushed
the
null_provider
branch
3 times, most recently
from
818e9ec to
40e4b1d
Compare
ionut-arm
previously approved these changes
Feb 15, 2024
| @@ -0,0 +1,77 @@ | |||
| // Copyright 2023 Contributors to the Parsec project. | |||
There was a problem hiding this comment.
Should this technically be 2024?
There was a problem hiding this comment.
I started the PR work in 2023 December :) So kept it. Should I switch to 24?
This patch adds supports for building bindings for the missing provider related bindings and other required types. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
This patch adds macros and other functions required for setting up the provider. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
This patch adds the NULL provider functionality without any crypto support. The idea of this patch is to provide a working openssl provider to add features on top off. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
This adds a new crate which helps in building a dynamic library for the parsec provider. Signed-off-by: Gowtham Suresh Kumar <[email protected]> shared merge
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The CI script is now updated with build steps and basic test commands to verify the dynamic loading of the parsec provider. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
dismissed stale reviews from ionut-arm and tgonzalezorlandoarm
via
39380ed
gowthamsk-arm
force-pushed
the
null_provider
branch
from
40e4b1d to
39380ed
Compare
|
Rebased the PR. |
ionut-arm
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds NULL provider functionality as a basic setup. There are 4 crates defined in the repo:
Apart from these, there are some basic test files (ci.sh and docker image) that will be part of the CI setup testing the implementation.
Signed-off-by: Gowtham Suresh Kumar [email protected]